-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent merges #29
Comments
I'm not bothered by that .xpi file. The other commits looked fine at first glance. Is there anything I need to look at specifically? |
Well, the XPI is probably OK but the version string got a "-simon" from me so I'd know what's going on from the Addons Tab. This will end up on AMO if you don't remove it, and I don't feel like having done such a great job here to deserve a designation ;) Anyway, the plugin XPI works for me, without regressions AFAICT, so the xpi should be fine. |
how so? the repo isn't linked to mozilla in any way suitable for automatic pulling of XPIs. I upload new versions to AMO manually when they're done, so no problem there. Unless I missed some cool new AMO feature |
Not automatically, but see https://github.com/poohsen/thunderlink/blame/master/install.rdf#L7 |
ah yes. that's right. I missed that change in the diff. thx! |
Hi,
please not that my PR #25, since it came from master, got updated to contain lots of stuff that perhaps shouldn't have been merged. Notably, I added a -simon to the version to avoid ambiguities and added packaged versions thereof.
You may want to get rid of that.
The text was updated successfully, but these errors were encountered: