Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings not visible in settings #26

Open
simonthum opened this issue Jul 21, 2015 · 9 comments
Open

Strings not visible in settings #26

simonthum opened this issue Jul 21, 2015 · 9 comments

Comments

@simonthum
Copy link
Contributor

On windows 7 x64 but not linux gentoo (probably also a different TB: Win7 is 38.1, Linux is probably older), I cannot see the strings configured. I seem to be able to change them and creating a link works as expected, but they're not visible in the dialog at all.

@poohsen
Copy link
Owner

poohsen commented Jul 21, 2015

can you provide a screenshot?

@simonthum
Copy link
Contributor Author

Vanilla tb settings:

image

Still my settings seem to be there:
image

@poohsen
Copy link
Owner

poohsen commented Jul 23, 2015

pretty sure this used to work with older TBs, so my guess is that there were some breaking API changes.
tbh: I don't know when I'll have the time to fix this...

@EnigmaSolved
Copy link
Contributor

I can confirm the same issue on my Thunderbird 38.1.0, Windows 7 x64. I agree with the prognosis that something must have changed in TB.

It is also not urgent (for me), given that I don't change my Thunderlink strings very often.

@simonthum
Copy link
Contributor Author

Given that the code isn't particulary exotic it's probably also worth the wait for the Mozilla to fix it.

@poohsen
Copy link
Owner

poohsen commented Jul 24, 2015

That's not what I meant to say. I don't think Thunderbird is broken per se. Something about handling preferences must've changed and thunderlink must be adapted to that

@simonthum
Copy link
Contributor Author

Sure, but perhaps that change is just a regression. I did not spot non-straightforwards things in that part of thunderlink to it is reasonable to wait a bit as other addons may be affected too.

A quick googling did not turn up candidates, however.

@kgorlen
Copy link

kgorlen commented May 3, 2017

This is still not fixed as of 45.8.0.

@mikehardy
Copy link
Contributor

Newly release version on official add-ons site has working preference display and setting, with the only remaining issue being that extensive themes (e.g., DeepDark) don't display combos and checkboxes. For majority cases it's working again though. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants