-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Asyncify Data End #49
Comments
Two ways I can think of doing this (one more preferred IMO than the other). Preferred: extract this value from the binary. We're already doing this when trying to determine the initial memory page size here. We'll need to analyze the wasm binary to find the best way to do this. I'd recommend the following approach:
If we can extract this stack size in a deterministic way with all asyncify-compiled modules, then we should continue with this approach. Fallback: Inject a getter into the wasm binary upon compilation. Maybe something like |
EDIT! before proceeding with the above, we should probably revisit this code here: javascript-client/packages/asyncify/src/AsyncWasmInstance.ts Lines 134 to 137 in 9aee0cf
It could actually be the case that we're overwriting existing values in the wasm module with our hard-coded ones in JS. |
Asyncify currently has a fixed data end pointer.
It should be a dynamic one that changes based on the built modules ASYNCIFY_STACK_SIZE.
The text was updated successfully, but these errors were encountered: