Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker handling and host information pages #458

Merged
merged 14 commits into from
Oct 8, 2023
Merged

Improve docker handling and host information pages #458

merged 14 commits into from
Oct 8, 2023

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Aug 25, 2023 •
edited
Loading

Summary

An assorted set of small changes. Most notably Polypheny now start on Linux systems without a udev library installed, like Alpine Linux.

Changes

  • Removed unused files
  • Added explicit mention of units in some information pages
  • Added a few timeouts so that Polypheny will fail faster when connecting to unavailable Docker instances
  • The host information page load the udev library on Linux for disk and network device information. This library is not always preinstalled (like on Alpine Linux), leading to crashes during startup. The disk information is skipped when the library is not available and the network information gathering was rewritten to use java.net.NetworkInterface which does not depend on that library.
  • Fixed a bug that could happen when deleting an adapter.

@gartens gartens marked this pull request as ready for review August 25, 2023 14:11
vogti
vogti approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti changed the title Small fixes and improvements Improve docker handling and host information pages Oct 8, 2023
@vogti vogti merged commit 5357ee5 into master Oct 8, 2023
34 checks passed
@vogti vogti deleted the misc-fixes branch October 8, 2023 12:19
danylokravchenko pushed a commit that referenced this pull request Jan 9, 2024
@gartens @danylokravchenko
Improve docker handling and host information pages (#458)
82730fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datomo datomo datomo approved these changes

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gartens @vogti @datomo