Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version field and constraints #9

Open
RichiH opened this issue Jun 9, 2021 · 3 comments
Open

Add version field and constraints #9

RichiH opened this issue Jun 9, 2021 · 3 comments

Comments

@RichiH
Copy link

RichiH commented Jun 9, 2021

No description provided.

@sdboyer
Copy link
Member

sdboyer commented Jun 10, 2021

Version attached to the PollyPackage schema? Yeah, that's certainly needed.

Not sure exactly what "constraints" would be, though - say more?

@RichiH
Copy link
Author

RichiH commented Jun 10, 2021

e.g. "match semver"

@sdboyer
Copy link
Member

sdboyer commented Jun 11, 2021

Match semver - so like a constraint range, e.g. ^v1.0.0, right? And match the semver of what - other pops on which the declaring pop depends? If so, three things:

  • I'm trying to avoid thinking about cross-pop dependencies for as long as possible (though i suspect that won't be very long). It's a larger version of the question in How should signals be injected into config objects? #6 - are references to certain objects done via strings, or CUE references? - made much more complicated by being spread across repos/requiring thinking about package management.
  • When we do get there, i'm gonna be pretty staunchly against using semver ranges. There's reasons, but it's too much to go down that rabbit hole right now.
  • I'll be easier to move on this one, but i'm also likely to be opposed to using semver at all to version polly packages. Semver numberings only really have meaning when there's at least an aspirational rule that can be applied to decide if a given change is backwards compatible or not. I'm not sure it's possible to construct such a rule for polly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants