Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use storageVersion name in Developer/Chain state/Storage tab instead of palletVersion #5460

Open
1 of 8 tasks
Marcin-Radecki opened this issue Jan 30, 2023 · 1 comment
Open
1 of 8 tasks
Labels
P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first.

Comments

@Marcin-Radecki
Copy link

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?

In Developer/Chain state/Storage tab we can see palletVersion, yet underneath key is :__STORAGE_VERSION__: (

const VERSION_KEY = ':__STORAGE_VERSION__:';
) . This can be confusing to the user as e.g. I was expecting storageVersion name instead.

Example from Polkadot:

image

  • What is the motivation for changing the behavior?

This change paritytech/substrate#9165 was introduced in polkadot-v0.9.9 so that by default all pallets would support StorageVersion versioning. Not sure if all chains upgraded to this so far, but nevertheless if the key we query already refers to :__STORAGE_VERSION__: , then I think we should call it on UI say as storageVersion.

  • Please tell us about your environment:
  • Version:

  • Environment:

    • Node.js
    • [ X] Browser
    • Other (limited support for other environments)
  • Language:

    • JavaScript
    • [X ] TypeScript (include tsc --version)
    • Other
@jacogr
Copy link
Member

jacogr commented Jan 30, 2023

It is a breaking change in the naming, which has snow-ball effects for users. (Generally these are not taken lightly). Will mark it as a (possible, future) rename since it may cause some confusion due to usage changes.

@TarikGul TarikGul added P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first. and removed needs investigation labels Oct 30, 2024
@TarikGul TarikGul moved this to P4 - Needs Investigation in Polkadot-js general project board Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first.
Projects
Status: P4 - Needs Investigation
Development

No branches or pull requests

3 participants