Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut UI should only show active shortcuts (make list dynamic) #10

Open
karendolan opened this issue May 1, 2024 · 0 comments
Open

Comments

@karendolan
Copy link

The keyboardShortcutsHelp shows shortcuts that are not active to the user either because the plugin is not loaded or the shortcut is disabled for some other reason. It is confusing to list shortcuts that don't do anything along with the active shortcuts. It would be cleaner to only list shortcuts that are active.

Here is a non-optimal (hardcoded) example of a dynamic keyboardShortCutsHelp plugin that uses the config file to determine the name of potentially active plugins and then query if they are loaded:
https://github.com/harvard-dce/opencast-contrib/blob/f/DCE-Paella-7-customizations/modules/engage-paella-player-7/src/plugins/es.upv.paella.override.keyboardShortcutsHelp.js

The plugin it overrides:
https://github.com/polimediaupv/paella-basic-plugins/blob/main/src/plugins/es.upv.paella.keyboardShortcutsHelp.js

This is a request to generalize a method to determine if the shortcut is functional or not in loaded player, so that only the active shortcuts are displayed in the help list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant