-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work after switching to attrs #45
Comments
Note: The example in Edit: For |
@noc0lour I'd say that |
No, somehow I expected in poliastro to be able to stick results from the CZML_extractor directly into a CZMLWidget, which is a poliastro issue not a czml3 issue. |
Oh, I see! Yep, |
(Copied from #44)
This already passes all the tests locally.
Things that will have to be reworked:
Things I removed and I'd like to bring back:
Things I'd like to review:
default=None
everywhere)isinstance
(we are inconsistently using positive and negative checks)__attrs_post_init__
but we could use@x.validator
instead http://www.attrs.org/en/stable/init.html#decorator)KNOWN_PROPERTIES
(can I iterate overattrs
properties now instead?)StripeOrientationValue
)Things I'd like to add in the future:
The text was updated successfully, but these errors were encountered: