Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for cosmos/ics23 NonMembershipProof types #16

Open
7 tasks
h5law opened this issue Jul 18, 2023 · 1 comment
Open
7 tasks

feat: Add support for cosmos/ics23 NonMembershipProof types #16

h5law opened this issue Jul 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@h5law
Copy link
Collaborator

h5law commented Jul 18, 2023

Objective

Add support for the "range based" non-membership proof types used in the cosmos/ics23 library.

Screenshot 2023-07-18 at 10 00 09

Origin Document

cosmos/ics23 issue #152

Goals

  • Add a new ProveExclusion function that can traverse the tree and looking for the key we aim to prove, once it has found a leaf it should collect the adjecent leaves and produce a proof for them.
  • Add a function to convert SparseMerkleProof objects into the relevent ics23.CommitmentProof types

Deliverable

  • SMT proof type conversion function to ics23 proof type
  • Prove nonmembership in accordance with the ics23 repo

Non-goals / Non-deliverables

  • Change existing proof logic

General issue deliverables

  • Update any relevant README(s)
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: go test ...
  • New tests or benchmarks: go test ...
  • All tests: go test -v

Creator: @h5law
Co-Owners: @h5law

@h5law h5law added the enhancement New feature or request label Jul 18, 2023
@h5law h5law self-assigned this Jul 18, 2023
@h5law h5law moved this to Backlog in V1 Dashboard Jul 24, 2023
@h5law h5law added the backlog label Jan 10, 2024
@h5law
Copy link
Collaborator Author

h5law commented Jan 10, 2024

This would require we index the tree, see [1] as a reference on how this works. But is currently not in focus or planned on being implemented.

[1] https://docs.aztec.network/concepts/advanced/data_structures/indexed_merkle_tree

@h5law h5law removed this from V1 Dashboard Jan 11, 2024
@h5law h5law added this to SMT Jan 11, 2024
@h5law h5law moved this to Backlog in SMT Jan 11, 2024
@h5law h5law removed the backlog label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant