Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Integrate the DeepSubTrie for the SM(S)T #11

Open
9 tasks
h5law opened this issue May 26, 2023 · 0 comments
Open
9 tasks

[Enhancement] Integrate the DeepSubTrie for the SM(S)T #11

h5law opened this issue May 26, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@h5law
Copy link
Collaborator

h5law commented May 26, 2023

Objective

Following the merge of PR #6 the DeepSparseMerkleSubTree type was removed. This issue aims to re-implement/add a new DeepSubTrie, now using the lazy loaded SMT as its base, for it to work with both the SMT and SMST.

The functionality should be close to the original deepsubtree implementation, instead now utilising the lazily loaded SMT.

This would enable batch updates to the trie - given leaves with a shared prefix an entire DST could be inserted at once

Origin Document

Original lazy loading PR

Goals

  • Integrate the previous deep subtree implementation with the new lazy loaded SMT
  • Ensure the DeepSubTrie works for both the SMT and SMST
  • Enable batch updates/deletions

Deliverable

  • Implement the DeepSubTrie functionality
  • Add unit tests and runnable examples
  • Add documentation on the DeepSubTrie and how it works
  • Add the methods required for batch updates and deletions

Non-goals / Non-deliverables

  • Break the SM(S)T in terms of backwards compatibility
  • Change the existing insertion/deletion logic (for a single key-value)

General issue deliverables

  • Update any relevant README(s)
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: go test ...
  • New tests or benchmarks: go test ...
  • All tests: go test -v

Creator: @h5law

@h5law h5law self-assigned this May 26, 2023
@h5law h5law added documentation Improvements or additions to documentation enhancement New feature or request tests labels May 26, 2023
@h5law h5law removed documentation Improvements or additions to documentation tests labels Jan 10, 2024
@h5law h5law changed the title [Enhancement] Integrate Deep Subtrees into the lazy loaded SMT [Enhancement] Integrate the DeepSubTrie for the SM(S)T Jan 10, 2024
@h5law h5law added this to SMT Jan 11, 2024
@h5law h5law moved this to Ready in SMT Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

1 participant