Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse item purchases per round? #50

Open
nmjohnson opened this issue Sep 8, 2021 · 6 comments
Open

Parse item purchases per round? #50

nmjohnson opened this issue Sep 8, 2021 · 6 comments

Comments

@nmjohnson
Copy link

Is your feature request related to a problem? Please describe.
Not really, this is just something that I think would be really helpful.

Describe the solution you'd like
The default output the parse in JSON format is really great, but one big thing I think would be really useful is identify all of the weapons and equipment purchased by person, per round. I like seeing how much money a team starts with, how much they spend, and what the "buy type" situation is, but it would be really nice to specifically know what setup each player has so any analysis can control for that.

Describe alternatives you've considered
I could certainly build out an algorithm to infer weapons (using money spent, buy type, and the weapons used to accrue kills), but it's going to be inherently imperfect. If the player never gets a kill, we don't know what weapon they used, and what happens if the player picks up a weapon off of the ground?

@pnxenopoulos
Copy link
Owner

Hey @nmjohnson, thanks for the feature request.

Adding buys is an easy addition, and we can add it in the next update.

In the meantime, you can see what a player's inventory in GameRounds -> Frames -> CT/T -> Players -> Inventory. Does this help?

@nmjohnson
Copy link
Author

Oh awesome. I did not realize that was in there. Thanks! That's probably good enough but I guess in theory someone could still swap weapons before the round starts, so adding buys whenever you get a chance would still be terrific.

@pnxenopoulos
Copy link
Owner

@nmjohnson There is also aggregate spend in GameRounds under CTSpend and TSpend, but I haven't investigated the veracity of these numbers.

In any case, I'll leave this open so I know to fix it in our next sprint. I'll close the issue when I add detailed spend info. Thanks for the suggestion!

@pnxenopoulos
Copy link
Owner

Did some more investigation today. It looks like in the Golang parser, there is a ItemPickup event that triggers whenever an item is picked up or bought. This might complicate things -- I was hoping for a built-in event. I'll ask around, and if we need to we can try to build an algorithm for it.

@pnxenopoulos
Copy link
Owner

Talked a bit with Markus since this library relies on his parser. Probably it would be a good idea to build it into his parser, so I will coordinate with him and see how we can add this type of event.

@JanEricNitschke
Copy link
Collaborator

JanEricNitschke commented Apr 26, 2023

This is still an open issue in Markus' parser. Maybe i can revive that discussion and ideally submit a PR if i manage.

markus-wa/demoinfocs-golang#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants