Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 pp website get #6259

Open
appieschot opened this issue Aug 21, 2024 · 13 comments · May be fixed by #6486
Open

New command: m365 pp website get #6259

appieschot opened this issue Aug 21, 2024 · 13 comments · May be fixed by #6486

Comments

@appieschot
Copy link
Member

appieschot commented Aug 21, 2024

Usage

m365 pp website get

Description

Gets information about the specified Power Pages websites.

Options

Option Description
--url [url] The URL of the website to retrieve. Specify either url, name or id.
-n --name [name] The name of the website to retrieve. Specify either url, name or id.
-i, --id [id] The WebSiteId (GUID) of the website to retrieve. Specify either url, name or id.
-e, --environmentName <environmentName> The name of the environment for which to retrieve Power Pages website from.

Examples

Retrieve Demo Power Pages website by name in the given environment.

m365 pp website get --name Demo --environmentName Default-d87a7535-dd31-4437-bfe1-95340acd55c5 

Retrieve Power Pages website using an id in the given environment as an Administrator.

Default properties

N/a

Checkout the model for details: https://learn.microsoft.com/en-us/rest/api/power-platform/powerpages/websites/get-websites#websitedto

And checkout #6256 as that uses the same properties

Additional Info

You can have a look at the logic behind: https://learn.microsoft.com/en-us/power-platform/developer/cli/reference/pages#pac-pages-list

@milanholemans milanholemans added new feature needs peer review Needs second pair of eyes to review the spec or PR labels Aug 21, 2024
@Jwaegebaert
Copy link
Contributor

Thanks @appieschot for writing out these specs. I've got a few remarks before we can continue:

  • We don't need to specify any default properties for a get command.
  • For url, name and id. The description specifies both which refers to two items but we've three options here.
  • For the description of the second example, let's leave out the GUID from there. It doesn't have that much meaning.
  • The description of asAdmin, is that correct? I don't think this has anything to do with AI builder models.

@appieschot
Copy link
Member Author

appieschot commented Aug 22, 2024

Fixed point 1, 3 and 4. Not sure what you mean with the 2nd point .. You have to specify one of the three options, not two .. Or atleast that was what I was trying to convey.

@Jwaegebaert
Copy link
Contributor

In point 2, I'm referring to the definition of both. Your sentence mentions three options and ends with but not both. Both typically refers to two items, but we have three here. I suggest we just remove but not both from the sentence. That would make it similar to how we do it with targeting lists, e.g., https://pnp.github.io/cli-microsoft365/cmd/spo/listitem/listitem-add.

Also, when we specify the options in our description, we can leave out the [ ] chars.

@appieschot
Copy link
Member Author

Done

@Jwaegebaert Jwaegebaert added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Aug 29, 2024
@ktskumar
Copy link
Contributor

May I work on this!

@Adam-it
Copy link
Member

Adam-it commented Sep 23, 2024

May I work on this!

all yours 👍

@Jwaegebaert
Copy link
Contributor

Hey @ktskumar, thank you for all the hard work you’ve put in, it’s really appreciated! We’ve noticed that you have several issues assigned that haven't yet been created with a PR. To ensure everyone has a chance to get involved, especially with Hacktoberfest, I’ll be unassigning you from some of these issues.

We recommend focusing on 1 to 2 issues at a time. Once you’ve submitted a PR for an issue, you can easily claim another open one. This approach helps you manage the workload more effectively and ensures you can give each task the attention it needs.

Thanks again for your continued contributions!

@ktskumar
Copy link
Contributor

ktskumar commented Oct 1, 2024

let me work on this..

@milanholemans
Copy link
Contributor

Hi @ktskumar, as @Jwaegebaert mentioned, we recommend that people focus on 1-2 issues at a time. Since you have 2 issues assigned to you without a PR, we recommend finishing these before claiming other issues. This will give other contributors the chance to work on this repo as well.

@nicodecleyre
Copy link
Contributor

Hi team! I'd love to help out with this issue. Is it okay if I take it up?

@milanholemans
Copy link
Contributor

Definitely!

@nicodecleyre
Copy link
Contributor

As per my understanding, this api.powerplatform.com is treated as you were an admin and there isn't a distinct between 'normal' and 'asAdmin'. Couldn't really find an answer in the documentation.

@appieschot, you have more insights in this matter?

@appieschot
Copy link
Member Author

appieschot commented Nov 11, 2024

You might be right; I have not investigated this in too much detail. If that is the case perhaps, we can best skip the --asAdmin property!

And sorry for the delay! 🙇‍♂️

@nicodecleyre nicodecleyre linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants