Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance spo web roleassignment commands with Microsoft Entra groups #6193

Open
2 tasks
milanholemans opened this issue Jul 27, 2024 · 4 comments · May be fixed by #6463
Open
2 tasks

Enhance spo web roleassignment commands with Microsoft Entra groups #6193

milanholemans opened this issue Jul 27, 2024 · 4 comments · May be fixed by #6463
Assignees
@nicodecleyre
Labels
enhancement work in progress

Comments

@milanholemans
Copy link
Contributor

Related to #6179

Let's extend command spo web roleassignment add and spo web roleassignment remove with 2 new options to add/remove Microsoft Entra groups.

Options Description
--entraGroupId [entraGroupId] ID of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...
--entraGroupName [entraGroupName] Display name of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...

Additionally, we should update the description of option --groupName [groupName] and make clear that this option is only used for SharePoint Online groups.

Todo:

  • Introduce 2 new options to add and remove command.
  • Clarify that option groupName is only for SharePoint Online groups.
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Jul 27, 2024
@Jwaegebaert Jwaegebaert added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 31, 2024
@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
@ktskumar
Copy link
Contributor

May I work on this

@Jwaegebaert
Copy link
Contributor

Hey @ktskumar, thank you for all the hard work you’ve put in, it’s really appreciated! We’ve noticed that you have several issues assigned that haven't yet been created with a PR. To ensure everyone has a chance to get involved, especially with Hacktoberfest, I’ll be unassigning you from some of these issues.

We recommend focusing on 1 to 2 issues at a time. Once you’ve submitted a PR for an issue, you can easily claim another open one. This approach helps you manage the workload more effectively and ensures you can give each task the attention it needs.

Thanks again for your continued contributions!

@nicodecleyre
Copy link
Contributor

Hi,

Can I work on this one please? 🙏

@milanholemans
Copy link
Contributor Author

Definitely, thanks!

@Adam-it Adam-it removed the hacktoberfest Issue perfect for hacktoberfest label Nov 3, 2024
@nicodecleyre nicodecleyre linked a pull request Nov 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicodecleyre nicodecleyre

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
5 participants
@milanholemans @ktskumar @nicodecleyre @Jwaegebaert @Adam-it