Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use networkx to delete downstream components #108

Open
trevorhardy opened this issue Jul 7, 2023 · 2 comments
Open

Use networkx to delete downstream components #108

trevorhardy opened this issue Jul 7, 2023 · 2 comments

Comments

@trevorhardy
Copy link
Collaborator

trevorhardy commented Jul 7, 2023

Related to #102. .del_objects() should not just delete objects that are children of the deleted objects but also those that are electrically connected using link objects (e.g. transformers, lines).

This will only work for radial networks (acyclic graphs); for meshed networks (cyclic graphs) we should only delete the existing component. Doing this right will likely take some fancy networkx work to make sure we're doing the safe and sensible thing. Lots of edge cases to think through.

@trevorhardy trevorhardy added this to the v1.3 milestone Aug 14, 2023
@trevorhardy
Copy link
Collaborator Author

Feature implemented not using networkx; waiting to be merged into develop branch.

@trevorhardy
Copy link
Collaborator Author

Current version now works with parent-child relationships but not those connected via lines.

@trevorhardy trevorhardy removed this from the v1.3 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant