create Rule1-6 #1532
create Rule1-6 #1532
Conversation
KarenWGard
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
JacksonJ-KC
docs/section1/Rule 1-6.md
Outdated
| - set a boolean has_renewables and set it to false: `has_renewables = false` | ||
| - look at each end use result: `for end_use_result in output_instance.annual_end_use_results:` | ||
| - check if the energy source for the end_use_result is "ON_SITE_RENEWABLES": `if end_use_result.energy_source == "ON_SITE_RENEWABLES":` | ||
| - set has_renewables to true and continue to rule assertion: `has_renewables = true; CONTINUE TO RULE ASSERTION` |
There was a problem hiding this comment.
maybe we could also check if the annual_site_energy_use >0 when the energy source = on site renewables
docs/section1/Rule 1-6.md
Outdated
|
|
||
|
|
||
| ## Rule Logic: | ||
| - get the baseline output schema: `output = B_RMD.output` |
There was a problem hiding this comment.
I think we should check this across each orientation, unless that is captured somewhere else. I know Jackson populated the schema for things that should match across the baseline orientations. Not sure if we also did this with with output schema.
There was a problem hiding this comment.
It was not done for the output schema but it seems like a good idea to take the same approach of adding those to the schema yaml/json and having the same rule cover them
There was a problem hiding this comment.
I addressed this by doing the following:
- look at each baseline model rotation: for rotation in [B_RMD, B_RMD_90, B_RMD_180, B_RMD_270]:``
No description provided.