Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ta.fill_from_file #70

Open
pthomadakis opened this issue Oct 30, 2024 · 0 comments
Open

Refactor ta.fill_from_file #70

pthomadakis opened this issue Oct 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pthomadakis
Copy link
Collaborator

Current ta.fill_from_file op expects an already existing sparse tensor as input and mutates its in place, generating memory side-effects.
To better adapt to mlir's semantics it would be more appropriate to refactor this op so that it is the own that generates the sparse tensor.
Example,
%0 = ta.sp_tensor_from_file(<filename>) : () -> !ta.sparse_tensor<...>
Similar to how tensor dialect's tensor.from_elements:
%0 = tensor.from_elements %a, %b, %c, %d, %e, %f : tensor<2x3xindex>

@pthomadakis pthomadakis added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant