Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profile-viewer] allow core and package times to be collapsed into app times #1

Open
pmuellr opened this issue Mar 13, 2019 · 0 comments

Comments

@pmuellr
Copy link
Owner

pmuellr commented Mar 13, 2019

It would be nice to consider app function times to include core function time, and probably other package function time. Eg, if an app function is using an expensive RegExp, or JSON.parse(), it would be nice to do the time accounting for the function using these, to that function itself.

I think this would just affect the time values, and nothing else.

I think the way this would work is that we'd look a function in the stack, and if it's an app function, any functions it calls that we'd want to collapse (core, or all non-app packages), we'd add it's self time to the function, and then recurse on that stack, eating subsequent collapsible entries.

In the case where a stack starts in a collapsible function, then all the collapsible functions up to the first non-collapsible would be added to that non-collapsible function.

What about stacks that only contain collapsible functions? I don't think there's anything we can do about those :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant