misc: remove MPIR_Context_id_t #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using shorter integer type for context id has little benefit since nearly all expressions will default to int and then the type truncation will be either ignored or cast away, thus serve no additional safety. It only creates noise when we do want to check conversion warnings. The original purpose (according to comments) is to conserve header space in active messages. We still can do that, just add cast -- better yet, add bound check -- when we fill the am header. Thus, replace MPIR_Context_id_t with int for simpler code.
|
test:mpich/ch3/most |
raffenet
reviewed
Dec 4, 2024
Optimize struct MPIDI_Message_match_parts to be 64-bit according to the design goal noted in the comment.
|
test:mpich/ch3/most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[This is one step toward merging #6189]
Using shorter integer type for context id has little benefit since nearly all expressions will default to int and then the type truncation will be either ignored or cast away, thus serve no additional safety. It only creates noise when we do want to check conversion warnings.
The original purpose (according to comments) is to conserve header space in active messages. We still can do that, just add cast -- better yet, add bound check -- when we fill the am header.
Thus, replace
MPIR_Context_id_twith int for simpler code.[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.