Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does PMI_Data_Pack description include "These errors cannot be detected during packing" #507

Open
dsolt opened this issue Mar 25, 2024 · 1 comment

Comments

@dsolt
Copy link
Contributor

dsolt commented Mar 25, 2024

Describe your question or clarification request here

In the Packing/Unpacking chapter there is text such as:

Note that any data to be packed that is not hard type cast (i.e., not type cast to a specific size) may lose
precision when unpacked by a non-homogeneous recipient. The PMIx_Data_pack function will do its best
to deal with heterogeneity issues between the packer and unpacker in such cases. Sending a number larger than
can be handled by the recipient will return an error code (generated upon unpacking) — the error cannot be
detected during packing.

If we know the process we are packing for, then presumably PMIx could gather whatever information it needed about the destination to be able to generate this error on the packing side. Why does it claim the error cannot be detected during packing?

Suggested Clarification

  1. explain why this is true if it is
  2. Remove it
  3. Say that "Implementations may choose not to detect this until it is unpacked"

References

Please list specific chapters/sections in the PMIx Standard related to your query.

@abouteiller
Copy link
Contributor

Discussion during ASC24Q2

  • the target provides the pmix version info, but it may not contain the target architecture (Scalability reasons)
  • hence the packing may be target agnostic: can't see the error at that point

TODO: decide if we need more clarification, or close issue altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants