Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs warning on stl export #33

Open
pekpuglia opened this issue Aug 17, 2022 · 3 comments
Open

Kwargs warning on stl export #33

pekpuglia opened this issue Aug 17, 2022 · 3 comments

Comments

@pekpuglia
Copy link

The ConstructiveGeometry.stl function generates the following warning when used:

┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr │ caller = _ at ConstructiveGeometry.jl:221 [inlined] └ @ Core ~/.julia/packages/ConstructiveGeometry/on6NG/src/ConstructiveGeometry.jl:221
Minimal reproducible example in the REPL:

julia> using ConstructiveGeometry
julia> c = cube(1)
Cube
julia> ConstructiveGeometry.stl("cube.stl", c)

I believe this is a simple matter of updating the way the kwargs Dict is used; i could not, however, find anything kwargs-related close to line 221, as specified in the message.

@plut
Copy link
Owner

plut commented Aug 18, 2022

I could not reproduce this — moreover, in the latest version, there is no stl() function. (It has been replaced by save()). Are you sure you have an up-to-date version?

@pekpuglia
Copy link
Author

Well, my package had version number 0.2.0, the same as that in Project.toml in the repo. I tried ]update Constructivegeometry, to no success, reinstalling the package, uninstalling and garbage-collecting and reinstalling, also to no success. Maybe if the minor version number was incremented, Julia would recognize there is a new version to be installed. I could manually delete the .julia folder, or some subfolder, but I have lots of environments and would rather not mess with them.

Is incrementing the minor version number something you could try?

@plut
Copy link
Owner

plut commented Aug 19, 2022

This is certainly something I will try (once I feel the code has stabilized enough to at least compile the examples in the docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants