Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boilerplate shouldn't use short-circuiting #3

Open
stuartpb opened this issue Apr 7, 2015 · 2 comments
Open

Boilerplate shouldn't use short-circuiting #3

stuartpb opened this issue Apr 7, 2015 · 2 comments
Labels
under consideration

Comments

@stuartpb
Copy link
Member

stuartpb commented Apr 7, 2015

See progrium/bashstyle#22.
@stuartpb
Copy link
Member Author

stuartpb commented Apr 7, 2015

I'm pretty much convinced this needs to happen, but doing so will be a sweeping refactor that touches quite nearly every script in every Plushu project (which is many more than the last time I tweaked this), so I'm holding off on it for right now.

@stuartpb
Copy link
Member Author

stuartpb commented Oct 6, 2017 •
edited
Loading

Honestly, looking at this a couple years later... why have tracing as part of the boilerplate at all? Is that really a great / useful idea? This seems more like a hangover from when I was copying idioms from Dokku; what'd be smart would be, if I really need tracing, to tweak the set flags as part of a branch in the relevant plugin(s) (see plushu/plushu#69) - or have a tool that just straight-up runs through scripts and hot-patches set -x into scripts on demand, as applicable.

This was referenced Oct 6, 2017
Open
Open
@stuartpb stuartpb mentioned this issue Feb 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
under consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartpb