Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do quote assignments #2

Open
stuartpb opened this issue Apr 7, 2015 · 0 comments
Open

Do quote assignments #2

stuartpb opened this issue Apr 7, 2015 · 0 comments
Labels
under consideration

Comments

@stuartpb
Copy link
Member

stuartpb commented Apr 7, 2015

One of the tenets of the style guide is that things are made to be consistent so that they don't have to be rewritten in a refactor (#1).

If the string being assigned gets a literal space, quotes need to be added to the assignment: I'm thinking that kind of goes against that style guide principle.

There are some other ways it feels kind of inconsistent, too, especially when it comes to syntax highlighting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
under consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartpb