Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some validation combination will keep figwheel from reloading #315

Open
sveri opened this issue Dec 10, 2015 · 7 comments
Open

Some validation combination will keep figwheel from reloading #315

sveri opened this issue Dec 10, 2015 · 7 comments

Comments

@sveri
Copy link

sveri commented Dec 10, 2015

Hi,

Today I had a funny evening tracking down some really strange behavior.
I setup a minimal example to reproduce that. Please checkout https://github.com/sveri/prismaticschemabug

The code in question is in https://github.com/sveri/prismaticschemabug/blob/master/src/schemabug/core.cljs

To reproduce start lein figwheelfrom a command line from the project. After compilation open the provided index.html from the resources folder. It will load the compiled javascript and print "a".
Now, change the (println "a") to (println "b").
The expected behavior is that figwheel reloads the changes, but nothing happens.

To fix it. comment line 22 and uncomment line 17.
Reload the page. It will print "b" now as expected.
Now change the println expression to print something else and figwheel will reload the changes as expected.

There is no error or stacktrace available. I have no idea what is going on here. The reason I provided the whole validation expression is, if I remove some of the other (s/one...) expression the reloading will work too.

Hopefully some of you can figure out what is wrong there, might also be figwheels fault, I have no clue.

Thanks for looking at it,
Sven

@w01fe
Copy link
Member

w01fe commented Dec 11, 2015

That's ... really weird. That String is just embedded in the errors as-is, so I'm not sure how Schema could be causing this -- might even be something weird with in JS-land. That said, we'll look into it when we get a chance. Thanks for the report!

@sveri
Copy link
Author

sveri commented Dec 11, 2015

I wish you good luck with it. This looks like the kind of stuff that somehow solves itself a year and some version updates later to just reintroduce itself again 2 years and more upgrades later if it is not urgent enough to work on.

@w01fe
Copy link
Member

w01fe commented Dec 11, 2015

I looked into it briefly, and couldn't figure out any root causes.

One thing I did notice is that if I comment out everything after the "print" and load the browser, then I can uncomment the stuff below and change "a" to "b" and back and it all works as expected. This leads me to believe it might be something to do with figwheel, although it could definitely be something weird with schema that triggers it.

Given I don't know much about figwheel, and don't see any error messages, I'm not sure how to make progress on this from here.

@sveri
Copy link
Author

sveri commented Dec 12, 2015

It seems like I cannot easily reproduce it just for clojure. I tried to contact the figwheel maintainer via slack. I'd say we wait if he has an opinion for this, if that is ok for you.

@w01fe
Copy link
Member

w01fe commented Dec 12, 2015

Sounds good, thanks!

On Sat, Dec 12, 2015 at 6:37 PM, sveri [email protected] wrote:

It seems like I cannot easily reproduce it just for clojure. I tried to
contact the figwheel maintainer via slack. I'd say we wait if he has an
opinion for this, if that is ok for you.


Reply to this email directly or view it on GitHub
#315 (comment).

@w01fe
Copy link
Member

w01fe commented Feb 22, 2016

Did you ever hear back from the figwheel maintainer?

@sveri
Copy link
Author

sveri commented Feb 23, 2016

Nope, unluckily not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants