Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Viewer is broken when run strapi in develop mode #164

Closed
AmmonLin opened this issue Dec 24, 2024 · 6 comments
Closed

Diff Viewer is broken when run strapi in develop mode #164

AmmonLin opened this issue Dec 24, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@AmmonLin
Copy link

Bug report

Describe the bug

When use the Diff viewer to inspect the config changes, got the following error message in develop mode:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of ConfigDiff.

the same message show on console many times.

Steps to reproduce the behavior

  1. npx create-strapi-app@latest and use all default settings.
  2. cd my-strapi-project && npm run develop
  3. create an admin user and login
  4. Go to 'http://localhost:1337/admin/settings/config-sync' and Make the initail export
  5. Change any settings to make config not up-to-date.
  6. Click the Config Name to see diff
  7. see error

Expected behavior

Diff viewer works as in the production mode.

Screenshots

image

Code snippets

N/A

System

  • Node.js version: 22.12.0
  • NPM version: 9.9.3
  • Strapi version: 5.6.0
  • Plugin version: 3.1.0
  • Database: sqlite
  • Operating system: Ubuntu 20.04.6 LTS in WSL (Windows 11 24H2)

Additional context

N/A

@boazpoolman boazpoolman added bug Something isn't working Needs investigation Further information is requested labels Dec 24, 2024
@boazpoolman
Copy link
Member

Hi @AmmonLin,

Thanks for reporting this bug.

Could you confirm the issue with version 3.0.4 of the plugin as well?

@AmmonLin
Copy link
Author

Could you confirm the issue with version 3.0.4 of the plugin as well?

@boazpoolman 3.0.3 and 3.0.4 also have this issue.

3.0.2 3.0.1 install fail on my computer.

2.1.0 works as well

@boazpoolman
Copy link
Member

Thank you.
I will investigate the issue.

@boazpoolman boazpoolman removed the Needs investigation Further information is requested label Dec 24, 2024
@boazpoolman
Copy link
Member

Confirmed.

Probably related to Aeolun/react-diff-viewer-continued#43

@boazpoolman
Copy link
Member

I've patched the issue in version 3.1.1.

Thanks for reporting it, and Merry Christmas 🎄

@AmmonLin
Copy link
Author

Thank you for your prompt response and swift patch! ❤️
Merry Christmas 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants