Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marimekko: cannot set custom color via datum #2677

Open
Linschlager opened this issue Dec 4, 2024 · 0 comments
Open

marimekko: cannot set custom color via datum #2677

Linschlager opened this issue Dec 4, 2024 · 0 comments

Comments

@Linschlager
Copy link

Describe/explain the bug
I want to use a Marimekko chart and configure custom colors using the { datum: someField } syntax. This works nicely in other charts, but for Marimekko this seems to not be behaving the same.

To Reproduce

https://codesandbox.io/p/sandbox/cntjxj

Expected behavior

Being able to configure the color per dimension by using the "datum" color variant

Desktop (please complete the following information):

  • OS: Linux
  • Browser Chromium
  • Version 130

Additional information

I'm not very familiar with the codebase, but my initial investigation lead to hooks.ts:233 where getColor gets the dimensionDatum which is in the process of being constructed. This does not have access to properties that are defined on the original dimensions and that are not otherwise used like id and value.

Therefore, this also partially affects the custom color variant as it doesn't have access to all the input properties.

@Linschlager Linschlager changed the title Marimekko cannot set custom color via datum marimekko: cannot set custom color via datum Dec 4, 2024
@Linschlager Linschlager reopened this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant