Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Aspect & 1.21 #292

Open
Tomographix opened this issue Jul 15, 2024 · 6 comments
Open

Fire Aspect & 1.21 #292

Tomographix opened this issue Jul 15, 2024 · 6 comments
Assignees

Comments

@Tomographix
Copy link

Hi, The Fire Aspect doesn't seem to work on stacked mobs in 1.21.

Running:

  • PaperSpigot 1.21 (Latest build as of 15 July
  • StackMob 5.9.1
@ploppyperson ploppyperson self-assigned this Jul 15, 2024
@ploppyperson
Copy link
Owner

What exactly isn't working?

@Tomographix
Copy link
Author

Fire Aspect is a vanilla Minecraft sword enchantment that sets the target on fire. When a mob that normally drops raw meat is killed while it is burning, or if a mob is killed in one shot, even if it is in water, it drops cooked meat.

In this situation, if you kill a stack of 200 pigs & 90% of the drops are raw porkchops when they should be 100% cooked porkchop - or at least this is how it worked prior to 1.21.

@ploppyperson
Copy link
Owner

I can only reproduce this when a mob is in rain. Is this the same for you?

@Tomographix
Copy link
Author

Ah no, rain is actually disabled on the server. Have got a short video here on Imgur: https://i.imgur.com/EdnbjZF.mp4

@ploppyperson
Copy link
Owner

Yeah so after some more testing seems to be that if you kill the mob in one hit then fire aspect doesn't apply, but if there are two hits it works fine... This may be a craftbukkit bug but needs further looking into.

Temp fix would be to disable use of loot tables in config.

ploppyperson added a commit that referenced this issue Jul 18, 2024
In 1.21, fire ticks are applied after death event occurs, so as a temporary? fix need to delay by one tick
@ploppyperson
Copy link
Owner

ploppyperson commented Jul 18, 2024

Thanks for the bug report.
There is a temp fix in cde56de, although whether this is actually a craftbukkit bug is uncertain since this is seems to be result of Mojangs changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants