Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named bees stacking in certain scenarios (hive confliction) #264

Open
andrewkm opened this issue Nov 7, 2022 · 9 comments
Open

Named bees stacking in certain scenarios (hive confliction) #264

andrewkm opened this issue Nov 7, 2022 · 9 comments

Comments

@andrewkm
Copy link

andrewkm commented Nov 7, 2022

Bug: https://ecocitycraft.com/forum/threads/.219236/
Quote: After some testing at both Zulu's bees and my own. I went to the bees, named them and they unstack and remain unstacked, BUT once they enter the hives and exit again they do eventually stack. I tested this on a fresh swarm of bees on my own, from hives and spawn eggs. The name-tags are working correctly, it looks like the issue here is the bee's entering the hive seems to change them/render the name useless and they stack eventually after exiting.

StackMob one commit behind, compiled against: e5b74af
Paper 1.19.2 Build 263
StackMob config: https://pastebin.com/fkKaEQFz

@andrewkm
Copy link
Author

Any ideas what I can do here @Nathat23

@Aurelien30000
Copy link
Contributor

Aurelien30000 commented Feb 8, 2023

Hello! A released bee seems considered as a new spawned entity, so stack logic is re-applied. We may have to add a specific BEEHIVE spawn reason check. For now, as a workaround, you can add this spawn reason to the blacklist or use and cancel StackSpawnEvent when needed, if it's really annoying for your server.

@andrewkm
Copy link
Author

Thank @Aurelien30000 :)
I will wait for you guys to add the BEEHIVE spawn reason, which would help a lot!

@andrewkm
Copy link
Author

Any updates on potentially implementing a fix here?

ploppyperson added a commit that referenced this issue Apr 15, 2023
Bees coming from hives trigger creature spawn event with SpawnReason BEEHIVE, however when using Paper's Entity#getEntitySpawnReason they retain their original spawn reason.

We could change it so that the spawn event uses the Paper method for checking blacklists etc, but there would be problems for spigot users, requiring checks for use of Paper. But if an entity was previously destacked - they would become stacked again.
@ploppyperson
Copy link
Owner

I have added a permanent fix.

@andrewkm
Copy link
Author

Thanks! Confirmed working :)

@andrewkm
Copy link
Author

andrewkm commented Sep 2, 2024

We've just got a report from the original player @ploppyperson that this is for some reason once again broken.
New report: https://ecocitycraft.com/forum/threads/s.225957/
Old report can be seen here: https://ecocitycraft.com/forum/threads/.219236/

After your initial permanent fix, everything seemed good once again and we removed the workaround of adding BEEHIVE spawn reason to the blacklist. However, now, out of the blue it is broken. I suspect Mojang changes have something to do with it. :(

Our config currently looks as such: https://pastebin.com/sCNErbpR

@andrewkm andrewkm reopened this Sep 2, 2024
@andrewkm
Copy link
Author

andrewkm commented Sep 2, 2024

It looks like going back to the workaround (adding BEEHIVE spawn reason to the blacklist) works as a temporary solution once more.

@Aurelien30000
Copy link
Contributor

Hey! Thanks for opening the report again. At first glance, it may be a minor commit overwrite problem.

@ploppyperson In the history, the fix has been "erased" since the merge of 11/08/2023: https://github.com/ploppyperson/StackMob-5/commits/master/src/main/java/uk/antiperson/stackmob/listeners/SpawnListener.java

ploppyperson added a commit that referenced this issue Sep 8, 2024
Bees coming from hives trigger creature spawn event with SpawnReason BEEHIVE, however when using Paper's Entity#getEntitySpawnReason they retain their original spawn reason.

We could change it so that the spawn event uses the Paper method for checking blacklists etc, but there would be problems for spigot users, requiring checks for use of Paper. But if an entity was previously destacked - they would become stacked again.

(description copied from 50d6ee0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants