-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named bees stacking in certain scenarios (hive confliction) #264
Comments
Any ideas what I can do here @Nathat23 |
Hello! A released bee seems considered as a new spawned entity, so stack logic is re-applied. We may have to add a specific |
Thank @Aurelien30000 :) |
Any updates on potentially implementing a fix here? |
Bees coming from hives trigger creature spawn event with SpawnReason BEEHIVE, however when using Paper's Entity#getEntitySpawnReason they retain their original spawn reason. We could change it so that the spawn event uses the Paper method for checking blacklists etc, but there would be problems for spigot users, requiring checks for use of Paper. But if an entity was previously destacked - they would become stacked again.
I have added a permanent fix. |
Thanks! Confirmed working :) |
We've just got a report from the original player @ploppyperson that this is for some reason once again broken. After your initial permanent fix, everything seemed good once again and we removed the workaround of adding BEEHIVE spawn reason to the blacklist. However, now, out of the blue it is broken. I suspect Mojang changes have something to do with it. :( Our config currently looks as such: https://pastebin.com/sCNErbpR |
It looks like going back to the workaround (adding BEEHIVE spawn reason to the blacklist) works as a temporary solution once more. |
Hey! Thanks for opening the report again. At first glance, it may be a minor commit overwrite problem. @ploppyperson In the history, the fix has been "erased" since the merge of 11/08/2023: https://github.com/ploppyperson/StackMob-5/commits/master/src/main/java/uk/antiperson/stackmob/listeners/SpawnListener.java |
Bees coming from hives trigger creature spawn event with SpawnReason BEEHIVE, however when using Paper's Entity#getEntitySpawnReason they retain their original spawn reason. We could change it so that the spawn event uses the Paper method for checking blacklists etc, but there would be problems for spigot users, requiring checks for use of Paper. But if an entity was previously destacked - they would become stacked again. (description copied from 50d6ee0)
Bug: https://ecocitycraft.com/forum/threads/.219236/
Quote: After some testing at both Zulu's bees and my own. I went to the bees, named them and they unstack and remain unstacked, BUT once they enter the hives and exit again they do eventually stack. I tested this on a fresh swarm of bees on my own, from hives and spawn eggs. The name-tags are working correctly, it looks like the issue here is the bee's entering the hive seems to change them/render the name useless and they stack eventually after exiting.
StackMob one commit behind, compiled against: e5b74af
Paper 1.19.2 Build 263
StackMob config: https://pastebin.com/fkKaEQFz
The text was updated successfully, but these errors were encountered: