Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table block: "minimalistic design" doesn't work together with "table color inverted" #4603

Open
tiberiuichim opened this issue Mar 23, 2023 · 9 comments
Assignees

Comments

@tiberiuichim
Copy link
Contributor

The text color is changed to white, but the background color is not changed. Probably the "minimalistic design" hardcodes background color?

Latest Volto master.

@BhuvaneshPatil
Copy link
Contributor

Hi @tiberiuichim , can you please provide the steps to reproduce this behavior.
Thank you.

@tiberiuichim
Copy link
Contributor Author

@BhuvaneshPatil create a table block, add some content to it, play around with its settings, in the sidebar.

@lord2anil
Copy link
Contributor

@tiberiuichim i think this issue in the "semantic-ui-react". if we use 'basic' and 'inverted' classes at same time background become white. Please assine me i will raise a PR soon.

Table.-.Semantic.UI.React.-.Google.Chrome.2023-03-24.01-13-38.mp4

@lord2anil
Copy link
Contributor

I created pR please have a look.

@shreyal0007
Copy link

i want to contribute in this. Kindly allow me to do so

@stevepiercy
Copy link
Collaborator

@shreyal0007 there is already an open pull request. We review PRs in the order received.

Meanwhile please see Volto contributing guidelines.

@shreyal0007
Copy link

shreyal0007 commented Apr 2, 2023 via email

@stevepiercy
Copy link
Collaborator

You are welcome to work on any open issue that does not have a pull request open as well. Good ones have a label of either 41 lvl: easy or 33 needs: docs. We especially need new people to add content to the User Manual because they have a fresh perspective that experienced developers lack. See:

However you must follow the contributing documentation, and sign the Plone Contributor Agreement, before we will look at any pull request.

@shreyal0007
Copy link

shreyal0007 commented Apr 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants