Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageScale.tag populates alt and title with same content #162

Open
thet opened this issue Oct 9, 2024 · 0 comments
Open

ImageScale.tag populates alt and title with same content #162

thet opened this issue Oct 9, 2024 · 0 comments

Comments

@thet
Copy link
Member

thet commented Oct 9, 2024

According to WAI standards from my understanding, the alt and title should not contain the same content - both are read aloud by screen readers.

In plone.namedfile.scaling.ImageScale.tag the alt and title attribute are set to the image title (self.title)‌ if both are empty: https://github.com/plone/plone.namedfile/blob/master/plone/namedfile/scaling.py#L157

This is wrong and should be fixed.

There is the alt-tag-behavior issue/PR plone/plone.app.contenttypes#700 which aims to add a behavior for images to edit alt tags. We should jump on that and fix this issue together with the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant