Config with default template

[gforcada]

No description provided.

[mister-roboto]

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[gforcada]

@jenkins-plone-org please run jobs

[mauritsvanrees]

LGTM.

But there are three failing tests in all four PR jobs.
Initial guess: the zpretty changes break something, but it is easy to blindly point there because that is the biggest change.

[mauritsvanrees]

LGTM.

But there are three failing tests in all four PR jobs. Initial guess: the zpretty changes break something, but it is easy to blindly point there because that is the biggest change.

Indeed zpretty is responsible for two of the three test failures.
@ale-rt

For example a template had this:

title="" lang="" disabled="" readonly=""

zpretty turned it into this:

disabled
lang=""
readonly
title=""

And this gives errors. These tests failed:

$ bin/test -s plone.app.contenttypes -m test_behaviors_collection
...
Failure in test test_collection_in_edit_form (plone.app.contenttypes.tests.test_behaviors_collection.CollectionBehaviorFunctionalTest.test_collection_in_edit_form)
Traceback (most recent call last):
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
  File "/Users/maurits/shared-eggs/cp311/plone.app.contenttypes-3.0.1-py3.11.egg/plone/app/contenttypes/tests/test_behaviors_collection.py", line 103, in test_collection_in_edit_form
    self.assertEqual(from_control.value, [])
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 873, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 1079, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 1061, in assertSequenceEqual
    self.fail(msg)
  File "/Users/maurits/.pyenv/versions/3.11.1/lib/python3.11/unittest/case.py", line 703, in fail
    raise self.failureException(msg)
AssertionError: Lists differ: ['CreationDate'] != []

First list contains 1 additional elements.
First extra element 0:
'CreationDate'

- ['CreationDate']
+ []

$ bin/test -s plone.app.relationfield -t schemaeditor.txt
...
File "/Users/maurits/shared-eggs/cp311/plone.app.relationfield-3.0.1-py3.11.egg/plone/app/relationfield/tests/../schemaeditor.txt", line 64, in schemaeditor.txt
Failed example:
    browser.getControl(name='form.widgets.portal_type:list').value
Expected:
    ['Event', 'Folder']
Got:
    ['Event']
----------------------------------------------------------------------
File "/Users/maurits/shared-eggs/cp311/plone.app.relationfield-3.0.1-py3.11.egg/plone/app/relationfield/tests/../schemaeditor.txt", line 97, in schemaeditor.txt
Failed example:
    sorted(my_field.source.query.get('portal_type'))
Expected:
    ['Event', 'Folder']
Got:
    ['Event']
----------------------------------------------------------------------
File "/Users/maurits/shared-eggs/cp311/plone.app.relationfield-3.0.1-py3.11.egg/plone/app/relationfield/tests/../schemaeditor.txt", line 145, in schemaeditor.txt
Failed example:
    browser.getControl(name='form.widgets.portal_type:list').value
Expected:
    ['Event', 'Folder']
Got:
    ['Event']
----------------------------------------------------------------------
File "/Users/maurits/shared-eggs/cp311/plone.app.relationfield-3.0.1-py3.11.egg/plone/app/relationfield/tests/../schemaeditor.txt", line 178, in schemaeditor.txt
Failed example:
    sorted(my_field.value_type.source.query.get('portal_type'))
Expected:
    ['Event', 'Folder']
Got:
    ['Event']

Fixed with commit bbca022.
I simply removed the empty attributes, because they were replaced by tal anyway.

Same for multiple and checked, and maybe others.

There is one other test failure. Technically zpretty introduced this one as well, but here it is simply a slightly different attribute output order, and a test in plone.restapi was too strict. Fixed here to work with the old and new code:
plone/plone.restapi#1603

[mauritsvanrees]

Strange, the gh-actions tests install plone.app.theming 5.0.2 that I released yesterday but is not in https://dist.plone.org/release/6.0-dev/constraints.txt: that has 5.0.0. Version 5.0.2 gives a configuration conflict due to the permission that we moved.
I see see the same locally with tox -e test.

We may need some extra tox options. Okay, this option works locally:

constrain_package_deps = true

See tox changelog. 4.4.0 introduced the option, setting it by default to true. 4.4.1 changed the default to false, to match what previous tox versions did. In our case we want it true.
Let's test it in this PR, and then we can consider it for plone.meta.

[mauritsvanrees]

That worked. :-)
Now Jenkins:

@jenkins-plone-org please run jobs

[petschki]

Just got the same problems in an addon. I've created an issue: malthe/chameleon#429