Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics_export extensibility #339

Open
ale-rt opened this issue Aug 4, 2021 · 1 comment
Open

ics_export extensibility #339

ale-rt opened this issue Aug 4, 2021 · 1 comment

Comments

@ale-rt
Copy link
Member

ale-rt commented Aug 4, 2021

The following lines:

if not (IEvent.providedBy(event) or IOccurrence.providedBy(event)):
# Must be an event.
continue
acc = IEventAccessor(event)

make it hard to extend the the ics_view to include other content types that do not directly provide the IEvent interface.

IMO the code should be changed to digest everything that can be adapted succesfully, i.e:

        acc = IEventAccessor(event, None)
        if not acc: 
            continue
        component = IICalendarEventComponent(event, None)
        if not component:
            continue
@ale-rt
Copy link
Member Author

ale-rt commented Aug 4, 2021

I hope I can deliver a PR for this, but that will not happen not soonish...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant