Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event_listing without results when default_page is a collection #279

Open
adnus opened this issue Mar 21, 2018 · 3 comments
Open

event_listing without results when default_page is a collection #279

adnus opened this issue Mar 21, 2018 · 3 comments

Comments

@adnus
Copy link

adnus commented Mar 21, 2018

Hi guys,

I'm not sure if this is a bug.

I would like a collection as the default page on my Plone site, in the root folder. The Idea is to list all the news on the start page of my site. That's working so far.

But when I do that, the <plone_site>/event_listing shows no results more.

I found this lines in the plone/app/event/browser/event_listing.py:

    # Try to get the default page
    default = get_default_page(context)
    self.default_context = context[default] if default else context

If I change it to

   self.default_context = context

the event_listing view shows the expected results, even if a collection is the default on the root folder of my plone site.

So my question is: What does this code do? What happens with self.default_context = context, or in other words: what will not work anymore.

I'm not a programmer, just a more advanced user ;-)

Greetings from Germany und many thanks!
Jens

@adnus adnus closed this as completed Sep 16, 2018
@sunew
Copy link
Contributor

sunew commented Sep 16, 2018

@adnus Hi Jens, I'd say this is a bug, so please keep it open. It will be looked at eventually:)
What versions of plone and plone.app.event?

@sunew sunew reopened this Sep 16, 2018
@adnus
Copy link
Author

adnus commented Sep 16, 2018

oh, ok, thanks! No problem. It's not an urgent thing.
I found this issue in the 5.0.8, plone.app.event-2.0.13.
I tried the 5.1, same results.

@sunew
Copy link
Contributor

sunew commented Sep 16, 2018

Great! thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants