Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is formatted_date.pt using html tag abbr? #277

Open
sunew opened this issue Mar 16, 2018 · 5 comments
Open

why is formatted_date.pt using html tag abbr? #277

sunew opened this issue Mar 16, 2018 · 5 comments

Comments

@sunew
Copy link
Contributor

sunew commented Mar 16, 2018

formatted_date.pt is using markup like this:
<abbr class="dtstart"
This renders in Chrome like:

workspace 1_551

(Double-dashed underline)

The cursor (in Chrome) is changed to a question mark.

Why use abbr in this case? It does not seem right to me.
"The HTML element represents an abbreviation or acronym " (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/abbr)

I can see the code is originating from @thet - perhaps you can answer the question?

@sunew
Copy link
Contributor Author

sunew commented Mar 16, 2018

Same formatting and cursor on hover in Firefox.

@sunew
Copy link
Contributor Author

sunew commented Mar 16, 2018

@sunew
Copy link
Contributor Author

sunew commented Mar 16, 2018

So: perhaps we should

  1. change the markup
    or
  2. style it, so it does not show the dashed underline and the question mark cursor on hover

Any opinions on this?

@thet
Copy link
Member

thet commented Mar 16, 2018

@sunew doesn't seem right to me either. I can't remember why I have done it that way.
I'm +1 for changing the markup, as the markup should be correct. We should probably change it to a <time> element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time

@sunew
Copy link
Contributor Author

sunew commented Mar 16, 2018

I did a little research, and I think a while back it was common to use abbr for some microformats use cases (I did not go into the details... ).

+1 for the time element.
But there is an issue with support in IE ? as described here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants