Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug or Feature: Selected items are delete even if they are not in current folder #3933

Open
krissik opened this issue Mar 28, 2024 · 5 comments

Comments

@krissik
Copy link
Contributor

krissik commented Mar 28, 2024

Assuming I have an folder 'demo' containing a page 'page1' and an folder 'folder1' which contains another page 'page2':

| demo
  |- page1
  |- folder1
     |- page2

In folder_contents-View I select 'page1' then click on 'folder1' and select 'page2'. Now I choose delete.

This happens:

  • Pop-Up shows and ask if I'm sure that I want to delete without given more information about what to delete
  • I click 'YES'
  • page1 and page2 are deleted

delete

What I would expect:

  • a) Pop-Up shows what to delete
  • b) Only page2 is deleted b/c it is confusing that selected items from outside the current folder are deleted

Is it a bug or a feature that selected items from outside the current folder are deleted too?

Volto behaves the same: plone/volto#5931

@pgrunewald
Copy link

pgrunewald commented Apr 30, 2024

I'd propose to automatically reset selections upon changing the folder. I think it's counter-intuitive anyway to "track" the selection across folders, because user are prone to lose track of the selected items. Other established systems known to users do not work this way.

@stevepiercy
Copy link
Contributor

I'd propose to automatically reset selections upon changing the folder. I think it's counter-intuitive anyway to "track" the selection across folders, because user are prone to lose track of the selected items. Other established systems known to users do not work this way.

We reached the same conclusion in the linked issue plone/volto#5931 (comment).

@petschki
Copy link
Member

The multiselection across page structure can be useful if you want to copy or move several items from different places to another folder. We had that usecase several times in the past. Though the deletion should maybe warn about deleting everything in the current selection which might not be obvious to the user.

@yurj
Copy link
Contributor

yurj commented Jun 20, 2024

At least we can print "You have selected X items" with a link to a popup that prints the list of selected items. But what about folders? If you select for a "change of status," you have a flag to recursively include contained items. If you select for a deletion, the included items are clearly included. In the first case, therefore, it is not clear whether the list should include contained elements. We can say "You potentially selected X elements" and still list them.

@petschki
Copy link
Member

petschki commented Jun 20, 2024

When deleting a folder, the potential link breakage and a summary of potentially deleted items are already there. try it on https://classic.demo.plone.org/en/folder_contents - select the demo folder and hit the delete button ... but if there are multiple items selected, its not trivial to give an overview on this ... the calculation on this is done in plone.app.content I think ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants