Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element "Number" can't call RTMP session #111

Open
evghenin opened this issue Jan 2, 2014 · 2 comments
Open

Element "Number" can't call RTMP session #111

evghenin opened this issue Jan 2, 2014 · 2 comments

Comments

@evghenin
Copy link

evghenin commented Jan 2, 2014

The problem is when I want bridge call to user which are connected through RTMP session. I'm trying to add "Number" element without specified gateways because I use ${rtmp_contact()} function as phone number, which returns correct contact string with gateway path. So, if we want to call RTMP session we have to have possibility to leave gateways attribute as array with single empty element.

My solution is:

File elements.py from the line 1238

    if gateways:
        # get list of gateways
        self.gateways = gateways.split(',')

replace to

    if gateways:
        # get list of gateways
        self.gateways = gateways.split(',')
    else:
        self.gateways = [""]

and in the same file from line 735

    #if not number_instance.gateways:
        outbound_socket.log.error("Gateway not defined on Number object !")
        return ''

replace to

    #if not number_instance.gateways:
    #    outbound_socket.log.error("Gateway not defined on Number object !")
    #    return ''
@mike-plivo
Copy link
Member

Hi Dammazz,

thanks for the feedback and sharing the code .
Can you do a pull request ?

evghenin added a commit to evghenin/plivoframework that referenced this issue Jan 2, 2014
@evghenin
Copy link
Author

evghenin commented Jan 2, 2014

Done! Waiting for your review, may be you can improve this things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants