Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn the user when trying to save a mapping with blank CO filters #8

Open
salihuM opened this issue Nov 3, 2021 · 1 comment
Open

Warn the user when trying to save a mapping with blank CO filters #8

salihuM opened this issue Nov 3, 2021 · 1 comment

Comments

@salihuM
Copy link

salihuM commented Nov 3, 2021

No description provided.

@plinnegan plinnegan changed the title Add a prompt if a CO is left so the user can confirm it wasn’t left blank in error Warn the user when trying to save a mapping with blank CO filters Nov 3, 2021
@plinnegan
Copy link
Owner

In some cases the user will want to leave CO filters blank because they are not required for this particular mapping, but it's also possible to accidentally leave a CO filter blank, in which case not all the expected PIs will be generated.

So it would be a good idea to display a warning to the user indicating that there are blank filters, and get them to confirm they are happy before saving the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@salihuM @plinnegan