Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor calculations concept #157

Open
1 of 3 tasks
codingfabi opened this issue May 4, 2024 · 0 comments
Open
1 of 3 tasks

refactor calculations concept #157

codingfabi opened this issue May 4, 2024 · 0 comments
Assignees
Labels

Comments

@codingfabi
Copy link
Contributor

codingfabi commented May 4, 2024

Rethink and refactor calculation architecture:

  • Streamline all different functions of calculations into a more clear hierarchy of calculation functions. Introduce calculate_co2_trip as basic function that serves as an abstract level on transportation mode calculations.
  • Include main calculation functions on root level and maintain enhanced functions (commuting, trips) in separate directory/submodules
  • Provide a way to add a custom emission factor for trips (optimal to do this via the configs object). I think we should handle this in a way to NOT look up an emission factor if the options object contains a custom_emission_factor entry.
@codingfabi codingfabi changed the title refactor: calculations refactor calculations concept May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant