Dev degreedays #139
Open
Dev degreedays #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 16, 2023
alexbercik
commented
Feb 16, 2023
co2calculator/degree_days.py
Outdated
| clnt = openrouteservice.Client(key=ORS_API_KEY) | ||
| call = openrouteservice.geocode.pelias_search(clnt, location) | ||
| for feature in call["features"]: | ||
| geom = feature["geometry"]["coordinates"] |
There was a problem hiding this comment.
Hannah comment: replace with a call to gocoding() or geocoding_structured() from distances.py?
There was a problem hiding this comment.
Second Hannah comment: Can the user also put in known coordinates directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in a file to calculate degree days (the actual correction / normalization to consumption will be done directly in the backend, as per the writeup made with Sarah)