Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'user was banned for this post' in post content #427

Open
plebeius-eth opened this issue Jul 2, 2024 · 2 comments
Open

add 'user was banned for this post' in post content #427

plebeius-eth opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

No description provided.

@plebeius-eth plebeius-eth self-assigned this Jul 2, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Jul 2, 2024
@plebeius-eth
Copy link
Member Author

f6c1fb4
9ee2c6c
1bccf87

@estebanabaroa
Copy link
Member

did you know that comment.commentAuthor only exists on useEditedComment() ? it's not actually part of the comment schema, the comment schema is only comment.author.subplebbit.banExpiresAt, and it doesn't specify which comment caused a user to be banned, so the "USER WAS BANNED FOR THIS POST" is actually only visible to the mod that banned the user.

unless rinse added comment.commentAuthor to the protocol schema and I never realized, it's not documented that it exists

so to display a banned user to everyone, you would actually use comment.author.subplebbit.banExpiresAt and it would not be possible to know which specific comment caused the user to be banned

maybe you could just display USER BANNED UNTIL xx/xx/xx until there's a way to actually know which post caused the user to be banned, we could add a way to do this in the protocol at some point

@estebanabaroa estebanabaroa reopened this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Waiting for API
Development

No branches or pull requests

2 participants