Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaded asynchttpclient sources are not published #85

Closed
domdorn opened this issue Mar 9, 2017 · 6 comments
Closed

shaded asynchttpclient sources are not published #85

domdorn opened this issue Mar 9, 2017 · 6 comments

Comments

@domdorn
Copy link
Member

domdorn commented Mar 9, 2017

shaded-asynchttpclient-1.0.0-M4-sources.jar is only 256 bytes big and contains only the manifest.mf file.

@wsargent
Copy link
Member

fixed

@wsargent
Copy link
Member

Okay, not fixed, but the sources is org.asynchttpclient

@domdorn
Copy link
Member Author

domdorn commented Apr 28, 2017

hmm... yeah, problem is debugging issues related to plays ws client that way..

the underlying problem seems to be, that the shading happens on bytecode level... just noticed this when I tried to replace those constants
https://github.com/AsyncHttpClient/async-http-client/blob/1b35dbe96a25b253ac0381ce59b826a8831a7cb7/client/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigHelper.java#L33

I'll see if I find a adequate solution for that.

@jhooda
Copy link

jhooda commented May 18, 2022

The problem is when attaching debugger with a running process using any shaded library. The non-shaded source code won't bind with the shaded classes that belong to the shaded packages such as

package play.shaded.ahc.io.netty.channel.nio;
...
public abstract class AbstractNioChannel extends AbstractChannel {

The source code is still 266 bytes, see, https://repo1.maven.org/maven2/com/typesafe/play/shaded-asynchttpclient/2.1.3/

So any plan to correctly publish shaded sources?

A workaround in case someone needs it

$ cd netty
$ mkdir -p transport/src/main/java/play/shaded/ahc
$ cp -a transport/src/main/java/io transport/src/main/java/play/shaded/ahc/.
$ find transport/src/main/java/play/shaded/ahc -name "*.java" -exec sed -i 's#package io\.#package play.shaded.ahc.io.#' {} \; -exec sed -i 's#import io\.#import play.shaded.ahc.io.#' {} \; -exec sed -i 's#import static io\.#import static play.shaded.ahc.io.#' {} \;

@mkurz
Copy link
Member

mkurz commented May 19, 2022

@jhooda Please open a new issue for that, thanks!

@jhooda
Copy link

jhooda commented May 20, 2022

Thanks @mkurz filed the new issue #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants