Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add proxy #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add proxy #473

wants to merge 1 commit into from

Conversation

wsargent
Copy link
Member

Fixes

Purpose

  • Adds ProxyType to Scala API.
  • ProxyServer is missing entirely from Java API, so adding.

@SethTisue
Copy link
Member

Is this something somebody still wants to try and push forward...?

@wsargent
Copy link
Member Author

@SethTisue I completely forgot I wrote this. Lemme review it for sanity :-)

@wsargent
Copy link
Member Author

Okay updated

wsargent
wsargent commented Aug 12, 2021
View reviewed changes
play-ahc-ws-standalone/src/main/java/play/libs/ws/ahc/DefaultWSProxyServer.java
import java.util.Objects;
import java.util.Optional;

public class DefaultWSProxyServer implements WSProxyServer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a proxy server implementation

wsargent
wsargent commented Aug 12, 2021
View reviewed changes
play-ahc-ws-standalone/src/main/java/play/libs/ws/ahc/StandaloneAhcWSRequest.java
@@ -243,6 +240,15 @@ public StandaloneAhcWSRequest setContentType(String contentType) {
return addHeader(CONTENT_TYPE.toString(), contentType);
}

@Override
public StandaloneWSRequest setProxyServer(WSProxyServer proxyServer) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set proxy server

wsargent
wsargent commented Aug 12, 2021
View reviewed changes
play-ahc-ws-standalone/src/main/java/play/libs/ws/ahc/StandaloneAhcWSRequest.java
return builder.build();
}

private ProxyServer createProxy(WSProxyServer proxyServer) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create java proxy

wsargent
wsargent commented Aug 12, 2021
View reviewed changes
play-ws-standalone/src/main/java/play/libs/ws/StandaloneWSRequest.java
* @param proxyServer the proxy server
* @return the modified WSRequest
*/
StandaloneWSRequest setProxyServer(WSProxyServer proxyServer);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add setProxyServer

wsargent
wsargent commented Aug 12, 2021
View reviewed changes
play-ws-standalone/src/main/java/play/libs/ws/WSProxyServer.java
import java.util.List;
import java.util.Optional;

public interface WSProxyServer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WSProxyServer interface

@SethTisue
Copy link
Member

Yay! Now, who wants to review this...?

@wsargent
Copy link
Member Author

I don't even know who's committer on play-ws now.

@SethTisue
Copy link
Member

usual suspects we could try and summon: @mkurz, @ignasi35, @octonato

@SethTisue
Copy link
Member

(I'd also be willing to just shrug and hit "merge" myself if no reviewers appear and if you believe the change to be safe.)

marcospereira
marcospereira reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty comment so that this will not be part of my "review requests" list.

Sorry for the noise.

@mkurz
Copy link
Member

mkurz commented Nov 1, 2023

@wsargent can you please rebase? Thanks!

@wsargent wsargent force-pushed the add-proxy branch 2 times, most recently from 9671441 to 67148c0 Compare November 4, 2023 21:00
@wsargent
Copy link
Member Author

wsargent commented Nov 4, 2023

@mkurz done!

@mkurz
Copy link
Member

mkurz commented Nov 6, 2023

@wsargent CI complaining:

Thanks!

@mkurz
Copy link
Member

mkurz commented Jun 27, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

rebase

✅ Branch has been successfully rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospereira marcospereira marcospereira left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No place to specify a socks4/5 proxy, unlike AsyncHttpClient
4 participants
@wsargent @SethTisue @mkurz @marcospereira