Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Jakarta Mail #261

Closed
mkurz opened this issue May 3, 2023 · 7 comments
Closed

Switch to Jakarta Mail #261

mkurz opened this issue May 3, 2023 · 7 comments

Comments

@mkurz
Copy link
Member

mkurz commented May 3, 2023

Just a reminder to switch from javax.mail.* to jakarta.mail.* and from javax.activation.* to jakarta.activation.* when possible.
This depends on commons-email however:

Probably Angus Mail will be used as implemention of Jakarta Mail 2.x.

(BTW: Also check this line in play-grpc, not sure if or when we should change that exclude.)

@mkurz
Copy link
Member Author

mkurz commented Jul 10, 2024

@mikesname
Copy link
Contributor

Upvoting this because I've just run into an incompatibility with Play Mailer and the Jakarta-based SMTP appender for the version of Logback used in Play 2.9. 🙍‍♂️

@mkurz
Copy link
Member Author

mkurz commented Sep 4, 2024

@mikesname Like written in my previous comment, there is a first milestone release of apache commons 2. If you want to help out you can git-checkout the the main branch and upgrade to the this first milestone. We could then release a M1 of next play-mailer as well which you coul make use of.

mikesname added a commit to mikesname/play-mailer that referenced this issue Sep 4, 2024
This addresses playframework#261 but is not yet ready for merging.
mikesname added a commit to mikesname/play-mailer that referenced this issue Sep 4, 2024
This addresses playframework#261 but is not yet ready for merging.
mikesname added a commit to mikesname/play-mailer that referenced this issue Sep 4, 2024
This addresses playframework#261 but is not yet ready for merging.
@mikesname
Copy link
Contributor

@mkurz I've put in a PR with the upgraded deps. I've tested locally and all seems good, but let me know what else needs doing for an M1 release. I'm not even sure what the new versions would be given that 9.x and 10.x are current for Play 2.9 and 3.0 respectively - 11.x and 12.x?. Thanks!

mkurz pushed a commit to mikesname/play-mailer that referenced this issue Oct 8, 2024
This addresses playframework#261 but is not yet ready for merging.
mkurz pushed a commit to mikesname/play-mailer that referenced this issue Oct 8, 2024
This addresses playframework#261 but is not yet ready for merging.
mkurz pushed a commit to mikesname/play-mailer that referenced this issue Oct 8, 2024
@mkurz
Copy link
Member Author

mkurz commented Oct 8, 2024

Thanks @mikesname - I've just published play-mailer 11.0.0-M1: https://github.com/playframework/play-mailer/releases/tag/11.0.0-M1
Please test it and let me know if it works for you:

libraryDependencies += "org.playframework" %% "play-mailer[-guice]" % "11.0.0-M1"

Also please report here:

BTW, you can use it even when with Play 2.9 - play-mailer does not actually depend on anything Play 3 specific (just for testing):
https://repo1.maven.org/maven2/org/playframework/play-mailer_2.13/11.0.0-M1/play-mailer_2.13-11.0.0-M1.pom
https://repo1.maven.org/maven2/org/playframework/play-mailer-guice_2.13/11.0.0-M1/play-mailer-guice_2.13-11.0.0-M1.pom

So from v11 on there will be just this one release for both Play lines (Pekko/Akka).

@mkurz mkurz closed this as completed Oct 8, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Play 2.10 / 3.1 (subject to change) Oct 8, 2024
@mikesname
Copy link
Contributor

@mkurz thanks very much for this. I can't claim to have tested every aspect of functionality yet but works well for my purposes on Play 2.9.5.

@mkurz
Copy link
Member Author

mkurz commented Oct 16, 2024

@mikesname Can you please also report overt at apache/commons-email#43 to let the commons-mail maintainer know? So we get a RC and/or final release faster, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants