Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Makerdiary board files, added usb dongle support #103

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

424778940z
Copy link

@424778940z 424778940z commented Jan 9, 2021

As title says.

Renamed those two Makerdiary board files since we are referring calling other board by their maker and name (e.g. Adafruit boards).
Didn't plan to change board name under Zephyr since they are kind of consistent.
Instead, added variant for Zephyr for them to work.

Also created PR on Zephyr for the dongle support.
zephyrproject-rtos/zephyr#31202

Tested, works fine.

@cujomalainey
Copy link

I think you changed the line endings because the diff is whole file. Makes it harder to identify what changed. Just an FYI.

@424778940z
Copy link
Author

424778940z commented Jan 9, 2021

I think you changed the line endings because the diff is whole file. Makes it harder to identify what changed. Just an FYI.

As I stated, two existing board file name has been changed, and yes it is on purpose.
boards/nrf52840_mdk.json → boards/makerdiary_nrf52840_mdk.json
boards/nrf52832_mdk.json → boards/makerdiary_nrf52832_mdk.json
The reason explained in the original post, added maker to the file name instead of calling everything nrf528xx_xxx.
We also have board files like following, which named as maker_model/nickname.json, Makerdairy should follow the same way.
96b_nitrogen.json
adafruit_clue_nrf52840.json
redbear_blenano2.json
thingy_52.json

About the line ending, I edited it under notepad++, only added variant for those two existing Makerdairy board.
I will double check on that.

@424778940z
Copy link
Author

424778940z commented Jan 9, 2021

Hummm strange, they were on Windows style line ending, which I never change it to, maybe Notepad++ get too "smart".
But they are fixed now lol.

@valeros
Copy link
Member

valeros commented Jan 12, 2021

Thanks for the PR. It doesn't seem like a good idea to rename boards that already has been released. As for the dongle board, it will be merged once a new Zephyr version is published.

@424778940z
Copy link
Author

@valeros Zephyr now have the dongle support files, I matched the name, could merge this PR?
Also I still suggest keep board names consistent and convert old name as some kind of alias.

@424778940z
Copy link
Author

hummm, seems we are still using zephyr 2.7.1, which do not have the nrf52840_mdk_usb_dongle board.
Could we move to newer version?

@mischief
Copy link

what's blocking this PR? i have this device too, using platformio for it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants