-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Makerdiary board files, added usb dongle support #103
base: develop
Are you sure you want to change the base?
Conversation
I think you changed the line endings because the diff is whole file. Makes it harder to identify what changed. Just an FYI. |
As I stated, two existing board file name has been changed, and yes it is on purpose. About the line ending, I edited it under notepad++, only added variant for those two existing Makerdairy board. |
Hummm strange, they were on Windows style line ending, which I never change it to, maybe Notepad++ get too "smart". |
Thanks for the PR. It doesn't seem like a good idea to rename boards that already has been released. As for the dongle board, it will be merged once a new Zephyr version is published. |
@valeros Zephyr now have the dongle support files, I matched the name, could merge this PR? |
hummm, seems we are still using zephyr 2.7.1, which do not have the |
what's blocking this PR? i have this device too, using platformio for it would be great. |
As title says.
Renamed those two Makerdiary board files since we are referring calling other board by their maker and name (e.g. Adafruit boards).
Didn't plan to change board name under Zephyr since they are kind of consistent.
Instead, added variant for Zephyr for them to work.
Also created PR on Zephyr for the dongle support.
zephyrproject-rtos/zephyr#31202
Tested, works fine.