-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use perform_now instead of perform #58
Comments
Yes please. I spent 2 hours trying to find why job failures doesn't trigger airbrake notifications until I found that the |
I agree. Is there any reason perform is used because of perform_now? |
As a workaround you can do something like this:
But I agree it would be better if perform_now is called by default Edit: in my case, this still doesn't report the error to Rollbar. It seems Crono catches the error elsewhere: Line 81 in 5b72e08
so you would need to monkey patch the |
I have the exact same use-case, reporting errors to Sentry. I came up with another work around that doesn't need monkey patching Crono. Assuming your jobs are subclass of
|
Would it be possible to use ActiveJob's
peform_now
instead ofperform
? The main reason I ask is that usingpeform_now
will call all of the ActiveJob callbacks and error handlers. The error handler callback is particularly important for reporting problems to a error reporting system like Sentry. Is there a reasonperform
was used instead ofperform_now
?The text was updated successfully, but these errors were encountered: