Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offering assistance and discussing upkeep / releases for vtprotobuf #89

Open
nockty opened this issue Aug 11, 2023 · 9 comments
Open

Offering assistance and discussing upkeep / releases for vtprotobuf #89

nockty opened this issue Aug 11, 2023 · 9 comments

Comments

@nockty
Copy link
Contributor

nockty commented Aug 11, 2023

Hello everyone,

I'd like to discuss the future maintenance of vtprotobuf. As an avid user from Datadog, I've recognized its potential in enhancing protobuf message operations. However, recent activity in the repository has been limited, with the last release dating back to January.

To bolster vtprotobuf's capabilities for developers, I propose exploring a more active maintenance and release cycle. Acknowledging the demands of open-source projects, I'm here to extend a hand, along with some of my coworkers from Datadog, to offer assistance.

Although notable bugs and promising ideas exist in pull requests and issues (like #83 and #54), no PRs have been merged since the beginning of the year. We're enthusiastic about bridging this gap and improving vtprotobuf's efficiency and robustness.

In this regard, I suggest opening a discussion on project maintenance and future releases. Our goal is collaborative growth, not imposition. Whether it's contributing code, managing issues, updating documentation, or handling releases, we are more than willing to step in.

Let's collectively ensure that vtprotobuf remains a valuable resource for developers. Your insights are vital, and I'm excited about the potential improvements we can achieve.

Looking forward to your thoughts and suggestions. Thank you for your time and consideration.

@vmg
Copy link
Member

vmg commented Aug 25, 2023

Hey @nockty, thanks for reaching out. You actually caught me off on paternity leave, which is the reason why the repository was basically frozen for the better part of this year. This is my bad -- I did not hand over this specific project before I left. Sorry about that!

But I'm back now, and really happy that DD is interested on helping maintain the library.

I know that lots of people rely on vtprotobuf at this point, including Vitess, but the project already does 100% of what we required it to do for Vitess RPC, so I've been finding it hard to spend more of my time working on it. Having maintainers that are not tied to Vitess itself will be helpful to ensure that vtprotobuf covers more use cases.

I'm gonna start by discussing the security implications of this internally. We may require to spin-off this into its own organization before we can add external contributors to the project. I'll let you know asap. Thanks again for your interest!

@gnagel
Copy link
Contributor

gnagel commented Aug 26, 2023

Hi @vmg ,
I too would like to offer support from TriggerMail to maintain this too! This is an awesome library and I would love to see it supported going forward.
Thanks,
Glenn

@nockty
Copy link
Contributor Author

nockty commented Aug 28, 2023

Hi @vmg, thank you for getting back to us, and congratulations on your paternity leave! It's completely understandable that life sometimes takes precedence.

I'm glad to hear that you're back and the project is getting attention again. It's exciting that DD's interest in maintaining vtprotobuf can align with the project's future and it's wonderful to see such positive engagement from the TriggerMail team as well.

I'm really looking forward to hearing from you about the next steps. Thanks for your responsiveness and dedication to the project!

@biosvs
Copy link
Contributor

biosvs commented Sep 1, 2023

Hi,

@nockty thanks for initiative and for rising this question!

@vmg here at Uber we're also looking for an alternative to outdated and abandoned gogo/protobuf project. And vtProto seems really promising!

But still we want to understands the desired future of this project:

  1. Does (will?) project have multiple owners/admins who may support activity, including sorting out issues, PRs and new releases?
  2. Who and how is (will?) making decision about features and approaches: what should be implemented, what should be left out of scope, etc.

As we're interested in this project, we also offer our help and participation in this project along with @nockty and @gnagel (at companies behind them) who already expressed their will.
Upd 02.10, we decided to move forward with a homemade tool, so I may be considered only as an external contributor.

Thanks!

@vmg
Copy link
Member

vmg commented Sep 4, 2023

Hey! I've reached out to PlanetScale's legal team and we're ironing out the last kinks. My goal is to add @nockty as a committer to this repository some day this week, since he has kindly offered his assistance on triaging and merging PRs. To anybody else who's is interested on helping out, please follow the normal OSS process: open PRs, review PRs, contribute in issues, etc.

As for final decisions on features: I intend to keep the final say on the direction of the project because the main goal of vtprotobuf is to enhance the Protocol Buffers performance in Vitess. Anything that regresses performance on the codebase or conflicts with it will not make it into the library. Besides that, I'm not fundamentally opposed to adding extra functionality to the library, and I'm easily swayed by good technical arguments, so I'm sure the project will continue to be very generally useful to the general public. As you're probably aware of, Vitess is rather representative of a large-scale Go project.

@vmg
Copy link
Member

vmg commented Sep 4, 2023

As a hint for people interesting on contributing to the library: I think the main open issue right now blocking our next release is (de)serialization support for well-known types. There's an open PR that implements it, but it's large and complex and I haven't gotten around to reviewing it yet. Testing it in your own projects and giving feedback would be immensely helpful.

@vmg
Copy link
Member

vmg commented Sep 6, 2023

@nockty: 👋 welcome back from your holidays! I've given you triage access to the repository. Thanks again for your interest on the project and let me know what can I do to make your life easier.

@nockty
Copy link
Contributor Author

nockty commented Sep 6, 2023

Awesome, thank you for your trust @vmg. I'll do my best to ensure that vtprotobuf succeeds in covering more use cases. I'm also thrilled to see that the project is getting active again, that's exciting!

I'll let you know if I need anything but in the meantime feel free to provide feedback at anytime so that I'm helping the project move in the right direction.

@anu-tiernan
Copy link

speaking of, it looks like there's a fix for oneof encoding in main but there hasn't been a release with that fix yet. Is there anything blocking cutting a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants