Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle System.Numerics.BigInteger type as GraphQL type #344

Open
boscohyun opened this issue Sep 26, 2024 · 4 comments · May be fixed by #350
Open

Handle System.Numerics.BigInteger type as GraphQL type #344

boscohyun opened this issue Sep 26, 2024 · 4 comments · May be fixed by #350
Assignees
@Arindam2002
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest mimir

Comments

@boscohyun
Copy link
Member

boscohyun commented Sep 26, 2024 •
edited by moreal
Loading

Overview

There is no GraphQL type for System.Numerics.BigInteger in Lib9c.GraphQL project. We need to implement Lib9c.GraphQL.Types.BigIntegerType that inherit ScalarType<BigInteger, StringValueNode> like Lib9c.GraphQL.Types.AddressType

References

Below items will be helpful when you work on this issue
@boscohyun boscohyun added bug Something isn't working enhancement New feature or request good first issue Good for newcomers mimir hacktoberfest labels Sep 26, 2024
@Arindam2002
Copy link

Hi, I'd like to help with this issue. Could I be assigned to it?

@moreal
Copy link
Contributor

moreal commented Sep 27, 2024

@Arindam2002 Of course! I assigned you on this issue 🙏🏻 💪🏻

Arindam2002 added a commit to Arindam2002/mimir that referenced this issue Sep 28, 2024
@Arindam2002
feat: Add BigIntegerType scalar type for GraphQL (planetarium#344)
1f761bb
@Arindam2002 Arindam2002 linked a pull request Sep 28, 2024 that will close this issue
Open
@Arindam2002
Copy link

Hey! I created the PR for this. A small request though, if the PR is all good, will it be possible to merge it from 1s October for it to be considered as a Hacktoberfest contribution as well? Thanks!

@moreal
Copy link
Contributor

moreal commented Sep 29, 2024

A small request though, if the PR is all good, will it be possible to merge it from 1s October for it to be considered as a Hacktoberfest contribution as well?

Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arindam2002 Arindam2002

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest mimir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BigIntegerType to GraphQL Types Arindam2002/mimir
3 participants
@boscohyun @moreal @Arindam2002