Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #341

Closed
moreal opened this issue Sep 24, 2024 · 8 comments
Closed

Fix typo #341

moreal opened this issue Sep 24, 2024 · 8 comments
Assignees
Labels

Comments

@moreal
Copy link
Contributor

moreal commented Sep 24, 2024

"{DiffCOunt} Handle in {Handler} Converted {Count} States",

DiffCOunt should be DiffCount.

@TheMarvelFan
Copy link
Contributor

Hi, is anyone working on this issue?
If not, I would like to take it up.

@Atralupus
Copy link
Member

Hi, is anyone working on this issue? If not, I would like to take it up.

Of course!

@TheMarvelFan
Copy link
Contributor

Hi @Atralupus,

I have created a PR for fixing this issue. Please review it and let me know if any changes are required.

Thanks!

@moreal
Copy link
Contributor Author

moreal commented Sep 27, 2024

Hi @TheMarvelFan, thanks for your contribution!! 🎉

I have a question about your Hacktoberfest participant.

Copied from https://hacktoberfest.com/participation/

Aim to submit four high-quality pull/merge requests between October 1 and October 31, with project maintainers accepting your pull/merge requests for them to count toward your total

According to the Hacktoberfest site, if you want to stack Hacktoberfest pull request count, it may need to be merged after October 1. Should I merge in October?

@TheMarvelFan
Copy link
Contributor

Thanks for asking @moreal!

It would be really helpful if you can do that.
I am currently working on another issue in this repo, and I would really appreciate it if you can merge that PR in October as well.

Thanks!

@moreal
Copy link
Contributor Author

moreal commented Sep 27, 2024

Okay I'll do, thank you!

@TheMarvelFan
Copy link
Contributor

TheMarvelFan commented Oct 1, 2024

Hi @moreal ,

It looks like I will have to recreate the PR. The following is from the Hacktoberfest website:

Pull/merge requests created before October 1 but merged or marked as ready for review after do not count.

@TheMarvelFan
Copy link
Contributor

@moreal @Atralupus
I have recreated the PR for this issue, and it is now able to be marged under Hacktoberfest.

@moreal moreal closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants