Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SetLegacyState(_, Null) with RemoveLegacyState(_) #2839

Open
moreal opened this issue Sep 22, 2024 · 1 comment
Open

Replace SetLegacyState(_, Null) with RemoveLegacyState(_) #2839

moreal opened this issue Sep 22, 2024 · 1 comment
Labels
good first issue Good for newcomers hacktoberfest refactoring Refactoring

Comments

@moreal
Copy link
Contributor

moreal commented Sep 22, 2024 •
edited
Loading

Motivation

Before Libplanet introduced the IAccount interface, there was no way to remove states. But since then, it is possible to remove states instead of setting them to Null.

Work items

Replace .SetLegacyState({address}, Null.Value) with .RemoveLegacyState({address})
@moreal moreal added good first issue Good for newcomers refactoring Refactoring labels Sep 22, 2024
@moreal moreal changed the title Use IAccount.RemoveState Replace SetLegacyState(_, Null) with RemoveLegacyState(_) Sep 22, 2024
@TheMarvelFan
Copy link

Hi @moreal ,

I would like to contribute to this issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moreal @TheMarvelFan