Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused methods and fields in ActionBase #2827

Closed
moreal opened this issue Sep 12, 2024 · 6 comments · Fixed by #2910
Closed

Cleanup unused methods and fields in ActionBase #2827

moreal opened this issue Sep 12, 2024 · 6 comments · Fixed by #2910
Assignees
Labels

Comments

@moreal
Copy link
Contributor

moreal commented Sep 12, 2024

There are some unused methods and fields in the ActionBase class. We want to make the ActionBase class clean without unused items. The following items should be removed:

Fields

  • Currency ActionBase.GoldCurrencyMock

Methods

  • IWorld ActionBase.LogError(IActionContext context, string message, params object[] values)
  • void ActionBase.CheckActionAvailable(long startedIndex, IActionContext ctx)
  • bool ActionBase.UseV100291Sheets(long blockIndex)
@Atralupus
Copy link
Member

Removing these unused items will help streamline the code and improve its readability. Could you please assign this task to me?

Sure! I just assigned you to this issue.

And we're also running a hackathon right now named Modathon. We'd love for you to check it out 🙏🏻

https://nine-chronicles.dev/event/2024modathon

@Atralupus Atralupus moved this from No Assignee to Assigned in Planetarium open-source contributor Oct 16, 2024
@umardevX
Copy link
Contributor

Removing these unused items will help streamline the code and improve its readability. Could you please assign this task to me?

@umardevX
Copy link
Contributor

@moreal Can you assign me on my this account again ?

@moreal
Copy link
Contributor Author

moreal commented Oct 16, 2024

@umardevX What is your relationship with @umar-source?

@umardevX
Copy link
Contributor

@umar-source is my second account. and umardevX account is my new account.

@moreal moreal assigned umardevX and unassigned umar-source Oct 17, 2024
@moreal
Copy link
Contributor Author

moreal commented Oct 17, 2024

Okay, I've changed assignee to @umardevX cc @umar-source

@moreal moreal moved this from Assigned to In Progress in Planetarium open-source contributor Oct 17, 2024
@moreal moreal linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants