Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of old ResultModel and unite to new model #2779

Open
U-lis opened this issue Aug 27, 2024 · 0 comments
Open

Get rid of old ResultModel and unite to new model #2779

U-lis opened this issue Aug 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request refactoring Refactoring

Comments

@U-lis
Copy link
Contributor

U-lis commented Aug 27, 2024

Currently, all the equipment crafting actions(CombinationEquipment, CustomEquipmentCraft, ItemEnhancement) are using different ResultModel (but based on same class: AttachmentActionResult).

Some of ResultModel are from old, unused legacy code (e.g., ItemEquipment7.ResultModel, RapidCombination5.ResultModel) wihch makes the codebase messy and difficult to manage.

We SHOULD refactor this to new united result model

NOTE

ResultModel is already in use on millions of sites, and the new result model can seamlessly migrate all the existing states.

@U-lis U-lis added enhancement New feature or request refactoring Refactoring labels Aug 27, 2024
@U-lis U-lis changed the title Get rid of old result model and unite them to new model Get rid of old ResultModel and unite to new model Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactoring
Projects
Status: Todo
Development

No branches or pull requests

1 participant